netdev - Re: [PATCH 1/2] xfrm4: fix the ports decode of sctp protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090703.191059.106410069.davem@davemloft.net>
Date:	Fri, 03 Jul 2009 19:10:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	yjwei@...fujitsu.com, netdev@...r.kernel.org,
	vladislav.yasevich@...com
Subject: Re: [PATCH 1/2] xfrm4: fix the ports decode of sctp protocol

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 3 Jul 2009 11:48:49 +0800

> On Fri, Jul 03, 2009 at 10:57:23AM +0800, Wei Yongjun wrote:
>> The SCTP pushed the skb data above the sctp chunk header, so the check
>> of pskb_may_pull(skb, xprth + 4 - skb->data) in _decode_session4() will
>> never return 0 because xprth + 4 - skb->data < 0, the ports decode of
>> sctp will always fail.
>> 
>> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied.

> Longer term I wonder if we can move this stuff into the protocol
> code, i.e., before they call xfrm_policy_check.

That ought to work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html