netdev - Re: tun netns BUG()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090705.190137.148499351.davem@davemloft.net>
Date:	Sun, 05 Jul 2009 19:01:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	ebiederm@...ssion.com, dwmw2@...radead.org, netdev@...r.kernel.org,
	johannes@...solutions.net
Subject: Re: tun netns BUG()

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 3 Jul 2009 23:25:47 +0800

> Eric W. Biederman <ebiederm@...ssion.com> wrote:
>> 
>> Not so.
>> 
>> unregister_netdevice
>>  rollback_registered
>>    tun_net_unit
>>      __tun_detach.
>> 
>> 
>> Further we need rtnl_lock around __tun_detach.
> 
> No we don't, tfile->count prevents this from occuring.  The async
> path will only __tun_detach if the count hits zero, in which case
> the first if clause in tun_chr_close will fail.  Conversely, if
> we're in the first if clause in tun_chr_close, then the async
> path either didn't execute at all or did not call __tun_detach.

I've applied Herbert's patch, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html