netdev - Re: [PATCH] NET: Fix locking issues in PPP, 6pack, mkiss and strip line disciplines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090713202725.32618249@lxorguk.ukuu.org.uk>
Date:	Mon, 13 Jul 2009 20:27:25 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	ralf@...ux-mips.org, netdev@...r.kernel.org,
	guido@...ntalancia.com, paulus@...ba.org,
	linux-hams@...r.kernel.org, hans@...ac.ele.tue.nl
Subject: Re: [PATCH] NET: Fix locking issues in PPP, 6pack, mkiss and strip
 line disciplines.

>	spin_lock_bh() --> BH disable in hard IRQ, OH NOEZ!

No I didn't see his original message just the patch - his original is a
fixed bug.

> mkiss_receive_buf(), the problematic code path, is invoked by
> the TTY layer directly from LDISC flushing and the TTY device's
> IRQ handler here.
> 
> How does networking's TX policy have anything to do with this?

Sorry I'd been looking at the other side stuff with ppp which is a
sleeping v bh issue and misinterpreted Ralf's post.

In fact Ralf's fix isn't needed. The incorrect uses of tty->low_latency
all got killed and the pty code got rewritten which was the other case
that could occur.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html