netdev - Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907162227.30362.IvDoorn@gmail.com>
Date:	Thu, 16 Jul 2009 22:27:30 +0200
From:	Ivo van Doorn <ivdoorn@...il.com>
To:	Tobias Klauser <klto@...w.ch>
Cc:	linville@...driver.com, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, users@...x00.serialmonkey.com
Subject: Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier

On Thursday 16 July 2009, Tobias Klauser wrote:
> Use the %pM conversion specifier for printk instead of print_mac.
> 
> Signed-off-by: Tobias Klauser <klto@...w.ch>

Acked-by: Ivo van Doorn <IvDoorn@...il.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800usb.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 3756166..da84afb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2224,10 +2224,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
>  	 */
>  	mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
>  	if (!is_valid_ether_addr(mac)) {
> -		DECLARE_MAC_BUF(macbuf);
> -
>  		random_ether_addr(mac);
> -		EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
> +		EEPROM(rt2x00dev, "MAC: %pM\n", mac);
>  	}
>  
>  	rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html