netdev - Re: [PATCH] USB host CDC Phonet network interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907171547.39815.oliver@neukum.org>
Date:	Fri, 17 Jul 2009 15:47:38 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB host CDC Phonet network interface driver

Am Freitag, 17. Juli 2009 11:56:06 schrieb Rémi Denis-Courmont:
> +       atomic_dec(&pnd->tx_queue);
> +       netif_wake_queue(dev);

Now that I think about it this seems to be a race condition.
What makes sure that your are still below the limit when you
wake the queue?

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html