netdev - Re: [PATCH] Phonet: sockets list through proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248085261.4549.103.camel@violet>
Date:	Mon, 20 Jul 2009 12:21:01 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Phonet: sockets list through proc_fs

Hi Remi,

> > > > > From: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
> > > >
> > > > isn't there are proper explaining commit message missing here?
> > >
> > > AFAIK, a one-liners stick to the Subject line.
> > >
> > > (I use explicit From: due to my broken Microsoft-provided MTA).
> >
> > the From: is not the problem here. However it would be nice to have a
> > description of the change. Especially details like this is for debugging
> > or this is a public API or etc.
> 
> It's just like most network protocols exposing their sockets list in 
> /proc/net. Debugging/monitoring indeed.

I think that for new protocols, we should not do this anymore and just
use debugfs. Since that is exactly its job.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html