[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090720.074113.89003675.davem@davemloft.net>
Date: Mon, 20 Jul 2009 07:41:13 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jarkao2@...il.com
Cc: paulmck@...ux.vnet.ibm.com, pstaszewski@...are.pl,
netdev@...r.kernel.org, robert@...ur.slu.se
Subject: Re: [PATCH net-next] Re: rib_trie / Fix inflate_threshold_root.
Now=15 size=11 bits
From: Jarek Poplawski <jarkao2@...il.com>
Date: Tue, 14 Jul 2009 20:33:08 +0200
> ipv4: Use synchronize_rcu() during trie_rebalance()
>
> During trie_rebalance() we free memory after resizing with call_rcu(),
> but large updates, especially with PREEMPT_NONE configs, can cause
> memory stresses, so this patch calls synchronize_rcu() in
> tnode_free_flush() after each sync_pages to guarantee such freeing
> (especially before resizing the root node).
>
> The value of sync_pages = 128 is based on Pawel Staszewski's tests as
> the lowest which doesn't hinder updating times. (For testing purposes
> there was a sysfs module parameter to change it on demand, but it's
> removed until we're sure it could be really useful.)
>
> The patch is based on suggestions by: Paul E. McKenney
> <paulmck@...ux.vnet.ibm.com>
>
> Reported-by: Pawel Staszewski <pstaszewski@...are.pl>
> Tested-by: Pawel Staszewski <pstaszewski@...are.pl>
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists