netdev - Re: [PATCH V2 net-next-2.6] net: relax dst refcnt in input path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A6708A6.1090200@trash.net>
Date:	Wed, 22 Jul 2009 14:40:06 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Mark McLoughlin <markmc@...hat.com>
Subject: Re: [PATCH V2 net-next-2.6] net: relax dst refcnt in input path

Eric Dumazet wrote:
> diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> index db46b4b..23e974b 100644
> --- a/net/ipv4/ip_input.c
> +++ b/net/ipv4/ip_input.c
> @@ -331,7 +331,7 @@ static int ip_rcv_finish(struct sk_buff *skb)
>  	 */
>  	if (skb_dst(skb) == NULL) {
>  		int err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos,
> -					 skb->dev);
> +					 skb->dev, 1);
>  		if (unlikely(err)) {
>  			if (err == -EHOSTUNREACH)
>  				IP_INC_STATS_BH(dev_net(skb->dev),


The packet might get queued by netfilter after this. I think this needs
another skb_dst_force() in __nf_queue().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html