netdev - Re: [PATCH] be2net: Adding support for 802.1ad (q-in-q mode)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090723092036.GB1761@serverengines.com>
Date:	Thu, 23 Jul 2009 14:50:37 +0530
From:	Sarveshwar Bandi <sarveshwarb@...verengines.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] be2net: Adding support for 802.1ad (q-in-q mode)

On 23/07/09 11:07 +0200, Patrick McHardy wrote:
> Sarveshwar Bandi wrote:
> > On 23/07/09 10:47 +0200, Patrick McHardy wrote:
> >> Sarveshwar Bandi wrote:
> >>> Please review and apply patch to net-next tree. Patch implements the 
> >>> support for q-in-q mode.
> >>
> >> Please describe your change more precisely. How does this interact with
> >> the stack and which VID is propagated to the VLAN code?
> >
> > Patch has code to check if the controller is in q-in-q mode. When the packet
> > has two vids, only the inner vid is passed onto the stack. The stack is never
> > made aware of the outer vid.
> 
> But you're still using the outer VLAN group when passing the packet to
> the VLAN code, so the association to the correct VLAN device can't work.
In the case where packet comes with two vlan ids, the rx descriptor contains
the inner vlan id and qnq is set to 1, the driver indicates this vid to the
stack.
In the case where packet comes with single vlan id, the rx descriptor
contains the outer vlan id and qnq is set to 0, the driver indicates this
packet as a non-vlan packet to the stack by calling netif_receive_skb.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html