netdev - Re: [PATCH] Add mac driver for w90p910

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090727.112459.224637019.davem@davemloft.net>
Date:	Mon, 27 Jul 2009 11:24:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcuos.com@...il.com
Cc:	linux@....linux.org.uk, soni.trilok@...il.com,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk,
	eric.y.miao@...il.com
Subject: Re: [PATCH] Add mac driver for w90p910

From: Wan ZongShun <mcuos.com@...il.com>
Date: Thu, 23 Jul 2009 12:52:24 +0800

> I fixed up previous mac driver and make a patch relative to it.

This patch does not apply to the code actually in the tree,
for example:

>  	ether->tdesc = (struct tran_pdesc *)
> -			dma_alloc_coherent(NULL, sizeof(struct tran_pdesc),
> -				(dma_addr_t *)&ether->tdesc_phys, GFP_KERNEL);
> +		dma_alloc_coherent(&pdev->dev, sizeof(struct tran_pdesc),
> +					&ether->tdesc_phys, GFP_KERNEL);
> +

in the tree there is a space between '(dma_addr_t *)' and
'&ether->tdesc_phys', but the code you are patching against
does not have that space.

Please do two things:

1) Generate your patch properly against the code actually in
   the tree.

2) Create a coherent, verbose, commit message and proper subject
   line which describes one-by-one the bug fixes you are making
   to the driver.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html