netdev - Re: [PATCH] Add some function overview comments in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090726.192321.257422911.davem@davemloft.net>
Date:	Sun, 26 Jul 2009 19:23:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Add some function overview comments in tcp_input.c

From: Andi Kleen <andi@...stfloor.org>
Date: Fri, 24 Jul 2009 11:47:19 +0200

> Add some function overview comments in tcp_input.c
> 
> Only partial so far. I didn't attempt to accurately comment
> the SACK machinery and the congestion state machine. 
> 
> I also fixed the grammar in one or two other comments
> (but still trying to keep the authentic "ANK language" @)
> 
> No code changes.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

Most of your comments sound exactly the same as what I
hear when I say the function's name out loud.

That's worse than wasted space.

What's the chapter from The Practice of Programming where
they advise against this with a bunch of amusing examples?
:-)

I'm not applying this, sorry.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html