netdev - Re: [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP checksum errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090726.202154.00452824.davem@davemloft.net>
Date:	Sun, 26 Jul 2009 20:21:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	donald.c.skidmore@...el.com
Subject: Re: [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP
 checksum errors

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 23 Jul 2009 21:00:39 -0700

> From: Don Skidmore <donald.c.skidmore@...el.com>
> 
> There is an 82599 errata that UDP frames with a zero checksum are
> incorrectly marked as checksum invalid by the hardware.  This was
> leading to misleading hw_csum_rx_error counts. This patch adds a
> test around this counter increase for this condition.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks.

But I wonder.   When you compute a checksum, and it's zero,
you have to use the complement as the checksum value.  How
does that relate to the problem being tackled here?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html