netdev - Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907280957.15889.remi.denis-courmont@nokia.com>
Date:	Tue, 28 Jul 2009 09:57:15 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members

On Monday 27 July 2009 18:09:08 ext Lucian Adrian Grijincu wrote:
> +#if defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE)
>  	void			*ax25_ptr;	/* AX.25 specific data */
> +#endif
> +#ifdef CONFIG_WIRELESS
>  	struct wireless_dev	*ieee80211_ptr;	/* IEEE 802.11 specific data,
>  						   assign before registering */
> +#endif

If I'm not mistaken, AX.25 can only be used with ARPHRD_AX25 devices, no? 
Should there be a single opaque pointer for all non-generic address families 
do, that would only be used by the one matching the header type?

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html