netdev - question about drivers/net/tg3.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0907291743300.22045@ask.diku.dk>
Date:	Wed, 29 Jul 2009 17:49:35 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	mcarlson@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org
Subject: question about drivers/net/tg3.c

The function tg3_reset_hw in the file drivers/net/tg3.c contains the code:

	/* If statement applies to 5705 and 5750 PCI devices only */
	if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 &&
             tp->pci_chip_rev_id != CHIPREV_ID_5705_A0) ||
	    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) {
                if ((tp->tg3_flags & TG3_FLG2_TSO_CAPABLE) &&
                    (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 ||
	             tp->pci_chip_rev_id == CHIPREV_ID_5705_A2)) {
	                /* nothing */
	        } else if (!(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH) &&
	                   !(tp->tg3_flags2 & TG3_FLG2_IS_5788) &&
			   !(tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS)) {
			val |= WDMAC_MODE_RX_ACCEL;
	        }
	}


On the fifth line above there is the code:

tp->tg3_flags & TG3_FLG2_TSO_CAPABLE

but the tg3_flags field seems to normally have a value whose name contains 
FLAG, and not FLG2.  Should this code be:

tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE

or should the constant be different?

julia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html