lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 30 Jul 2009 22:22:11 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	Socketcan-core@...ts.berlios.de,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH V3] CAN: Add Flexcan CAN controller driver

Wolfgang Grandegger wrote:
> Sascha Hauer wrote:
[...]
>> 	errcnt = readl(&regs->errcnt);
>> 	rxerr = (errcnt >> 8) & 0xff;
>> 	txerr = errcnt & 0xff;
>> 	if ((rxerr >= 96 || txerr >= 96) && state == CAN_STATE_ERROR_ACTIVE)
>> 		state = CAN_STATE_ERROR_WARNING;
> 
> Yes, or do not handle the state in the "case 0" above appropriately. The
> CAN spec only specifies the bus error states error active, error passive
> and bus off. The warning is somehow optional but available on most CAN
> controllers. Nevertheless, we should create a message if the ISR
> realizes a state changes.

FYI, I will be on holiday for the next 1.5 weeks.

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists