netdev - Re: [PATCH] eexpress: Read buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090730.132825.03094033.davem@davemloft.net>
Date:	Thu, 30 Jul 2009 13:28:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	roel.kluin@...il.com, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] eexpress: Read buffer overflow

From: Jarek Poplawski <jarkao2@...il.com>
Date: Wed, 29 Jul 2009 22:05:17 +0200

> On Wed, Jul 29, 2009 at 03:18:56PM +0200, Roel Kluin wrote:
>> start_code is 69 words, but the code always writes a multiple of 16 words,
>> so the last 11 words written are outside the array.
>> 
>> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
>> ---
>> > Now you seem to make my previous math working :-)
>> > 
>> >>> (max) i = 64, (max) j = 14, (64+14+16)/2 = 47 < 69, so it seems to copy
>> >>> less than its size?
>> > 
>> > Jarek P.
>> > 
>> 
>> You're right, thanks for reviewing, this one should be correct.
> 
> Looks OK to me.

Applied.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html