netdev - Re: [PATCH] sky2: Avoid transmits during sky2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090803085924.2b92b7b1@nehalam>
Date:	Mon, 3 Aug 2009 08:59:24 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	mikem@...g3k.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: Avoid transmits during sky2_down()

On Sun, 02 Aug 2009 13:09:12 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Mike McCormack <mikem@...g3k.org>
> Date: Fri, 31 Jul 2009 20:57:42 +0900
> 
> > I am aware you object to storing extra state, but I can't see a way
> > around this. Without remembering that we're restarting,
> > netif_wake_queue() is called in the ISR from sky2_tx_complete(), and
> > netif_tx_lock() is used in sky2_tx_done().  If anybody can see a way
> > around this, please let me know.
> 
> Stephen please do something about this, soon.
> 
> Michael has been trying to get this fixed for more than a month, and
> if you don't have a better fix like right now then we should put his
> fix in for the time being.
> 
> Sky2 patches are ones that consistently rot in patchwork and I'd
> appreciate if it that trend would cease, thanks.

Well, Mike's next set of patches is great, so the wait was worth it.

Some of us developer's get paid for doing things. There was a little
thing like a major release from our small engineering organization
at Vyatta to get done. Unlike the cushy life at other companies, in
a small company the engineers have to deal with customer issues,
bugzilla bugs.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html