netdev - Re: neigh_periodic_timer expires too often

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090802.183553.257296569.davem@davemloft.net>
Date:	Sun, 02 Aug 2009 18:35:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	luciano.coelho@...ia.com, netdev@...r.kernel.org,
	tero.kristo@...ia.com
Subject: Re: neigh_periodic_timer expires too often

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 30 Jul 2009 15:15:07 +0200

> [PATCH net-next-2.6] neigh: Convert garbage collection from softirq to workqueue
> 
> Current neigh_periodic_timer() function is fired by timer IRQ, and
> scans one hash bucket each round (very litle work in fact)
> 
> As we are supposed to scan whole hash table in 15 seconds, this means
> neigh_periodic_timer() can be fired very often. (depending on the number
> of concurrent hash entries we stored in this table)
> 
> Converting this to a workqueue permits scanning whole table, minimizing
> icache pollution, and firing this work every 15 seconds, independantly
> of hash table size.
> 
> This 15 seconds delay is not a hard number, as work is a deferrable one.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html