netdev - Re: [PATCH] Phonet: sockets list through proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090803024237.GI25334@ghostprotocols.net>
Date:	Sun, 2 Aug 2009 23:42:37 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Phonet: sockets list through proc_fs

Em Mon, Jul 20, 2009 at 12:31:41PM +0200, Eric Dumazet escreveu:
> Marcel Holtmann a écrit :
> > Hi Remi,
> > 
> >>>>>> From: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
> >>>>> isn't there are proper explaining commit message missing here?
> >>>> AFAIK, a one-liners stick to the Subject line.
> >>>>
> >>>> (I use explicit From: due to my broken Microsoft-provided MTA).
> >>> the From: is not the problem here. However it would be nice to have a
> >>> description of the change. Especially details like this is for debugging
> >>> or this is a public API or etc.
> >> It's just like most network protocols exposing their sockets list in 
> >> /proc/net. Debugging/monitoring indeed.
> > 
> > I think that for new protocols, we should not do this anymore and just
> > use debugfs. Since that is exactly its job.
> 
> netstat uses /proc/net
> 
> iproute2 uses netlink
> 
> Now you suggest adding debugfs support ?
> 
> What a mess...

Exactly, the proper way to do that is to have a base class for
inet_diag, net_diag, from where phone would be derived. But yeah, that
requires more work than cut'n'pasting from the old, /proc based way of
doing things 8-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html