netdev - Re: [PATCH] sky2: Avoid transmits during sky2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090803.190421.86873954.davem@davemloft.net>
Date:	Mon, 03 Aug 2009 19:04:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mikem@...g3k.org
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: Avoid transmits during sky2_down()

From: Mike McCormack <mikem@...g3k.org>
Date: Fri, 31 Jul 2009 20:57:42 +0900

> This patch supersedes my previous patch "sky2: Avoid transmitting
> during sky2_restart".
> 
> I have reworked the patch to avoid crashes during both sky2_restart()
> and sky2_set_ringparam().
> 
> Without this patch, the sky2 driver can be crashed by doing:
> 
> # pktgen eth1 &    (transmit many packets on eth1)
> # ethtool -G eth1 tx 510
> 
> I am aware you object to storing extra state, but I can't see a way
> around this. Without remembering that we're restarting,
> netif_wake_queue() is called in the ISR from sky2_tx_complete(), and
> netif_tx_lock() is used in sky2_tx_done().  If anybody can see a way
> around this, please let me know.
> 

Applied, thanks Mike.

> ----
> 
> During sky2_restart() or sky2_set_ringparam(), the tx queue needs to be
>  shutdown in sky2_down() to avoid accessing a NULL tx_ring.
> 
> Signed-off-by: Mike McCormack <mikem@...g3k.org>

Mike, please don't put your signoff after the "----" seperator,
otherwise automated tools strip it out instead of including it
in the commit message.

Also.

> @@ -2359,7 +2370,7 @@ static inline void sky2_tx_done(struct
> net_device *dev, u16 last)

Your email client breaks up long lines and this corrupts your
patches.  Please correct this before future submissions.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html