netdev - Re: [PATCH] sky2: Add a mutex around ethtools operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090805174241.6c8be715@nehalam>
Date:	Wed, 5 Aug 2009 17:42:41 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	netdev@...r.kernel.org, Rene Mayrhofer <rene@...rhofer.eu.org>,
	Richard Leitner <leitner@...s.at>
Subject: Re: [PATCH] sky2: Add a mutex around ethtools operations

On Thu, 06 Aug 2009 07:46:02 +0900
Mike McCormack <mikem@...g3k.org> wrote:

> As multiple sky2 devices share some of the same hardware, and ethtool
> operations are per device, access to transmit timers, eeprom access,
>  coalesce, etc. should be serialized.
> 
> Only tested on a single port card, as my sky2 doesn't have dual ports.
> 
> Signed-off-by: Mike McCormack <mikem@...g3k.org>

NAK.
The ethtool operations are already serialized by rtnl mutex at
higher level.  See net/core/dev.c 
-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html