netdev - Re: [PATCH] sky2: Serialize access to PCI config space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090806083436.2879bf7b@nehalam>
Date:	Thu, 6 Aug 2009 08:34:36 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	netdev@...r.kernel.org, Rene Mayrhofer <rene@...rhofer.eu.org>,
	Richard Leitner <leitner@...s.at>
Subject: Re: [PATCH] sky2: Serialize access to PCI config space

On Thu, 06 Aug 2009 20:10:27 +0900
Mike McCormack <mikem@...g3k.org> wrote:

> PCI config space may be shared across two device instances,
>  or accessed from an interrupt
>  , so serialize access so
>  read-update-write operations do not interfere with each other.
> 
> Only tested on a single port card, as my sky2 doesn't have dual ports.
> 
> Signed-off-by: Mike McCormack <mikem@...g3k.org>

No, more locks is not better design.  Better to just use existing
RTNL mutex consistently.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html