netdev - Re: [patch for 2.6.31? 2/2] gigaset: really fix chars_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090806.202227.224933454.davem@davemloft.net>
Date:	Thu, 06 Aug 2009 20:22:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, tilman@...p.cc, greg@...ah.com
Subject: Re: [patch for 2.6.31? 2/2] gigaset: really fix chars_in_buffer

From: akpm@...ux-foundation.org
Date: Thu, 06 Aug 2009 15:19:32 -0700

> From: Tilman Schmidt <tilman@...p.cc>
> 
> The tty_operation chars_in_buffer() is not allowed to return a negative
> value to signal an error.  Corrects the problem flagged by commit
> 23198fda7182969b619613a555f8645fdc3dc334, "tty: fix chars_in_buffers".
> 
> Signed-off-by: Tilman Schmidt <tilman@...p.cc>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

I was letting Alan Cox handle changes in this area since it's
TTY stuff, and thus it probably should go to the new TTY
mad man, CC:'d :-)

> ---
> 
>  drivers/isdn/gigaset/interface.c |   19 +++++++------------
>  1 file changed, 7 insertions(+), 12 deletions(-)
> 
> diff -puN drivers/isdn/gigaset/interface.c~gigaset-really-fix-chars_in_buffer drivers/isdn/gigaset/interface.c
> --- a/drivers/isdn/gigaset/interface.c~gigaset-really-fix-chars_in_buffer
> +++ a/drivers/isdn/gigaset/interface.c
> @@ -408,33 +408,28 @@ static int if_write_room(struct tty_stru
>  	return retval;
>  }
>  
> -/* FIXME: This function does not have error returns */
> -
>  static int if_chars_in_buffer(struct tty_struct *tty)
>  {
>  	struct cardstate *cs;
> -	int retval = -ENODEV;
> +	int retval = 0;
>  
>  	cs = (struct cardstate *) tty->driver_data;
>  	if (!cs) {
>  		pr_err("%s: no cardstate\n", __func__);
> -		return -ENODEV;
> +		return 0;
>  	}
>  
>  	gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__);
>  
> -	if (mutex_lock_interruptible(&cs->mutex))
> -		return -ERESTARTSYS; // FIXME -EINTR?
> +	mutex_lock(&cs->mutex);
>  
> -	if (!cs->connected) {
> +	if (!cs->connected)
>  		gig_dbg(DEBUG_IF, "not connected");
> -		retval = -ENODEV;
> -	} else if (!cs->open_count)
> +	else if (!cs->open_count)
>  		dev_warn(cs->dev, "%s: device not opened\n", __func__);
> -	else if (cs->mstate != MS_LOCKED) {
> +	else if (cs->mstate != MS_LOCKED)
>  		dev_warn(cs->dev, "can't write to unlocked device\n");
> -		retval = -EBUSY;
> -	} else
> +	else
>  		retval = cs->ops->chars_in_buffer(cs);
>  
>  	mutex_unlock(&cs->mutex);
> _
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html