lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Aug 2009 02:06:25 +0200 From: Phil Sutter <n0-1@...ewrt.org> To: netdev@...r.kernel.org Cc: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller" <davem@...emloft.net>, florian@...nwrt.org, Roel Kluin <roel.kluin@...il.com> Subject: Re: [PATCH] korina: Read buffer overflow Hi, Testing of my approach to solve the buffer overrun issue showed that living with a subset of the requested receive descriptors is not as easy as initially assumed: uppon allocation failure the number of descriptors would have to be reduced to the next lower power of two (as also stated in the corresponding define's comment), which I consider too much overhead. A better solution would be to export the ring parameters via ethtool. For now, let's go Roel's way aborting completely and cleaning up in this case. The following series fixes the incorrect printk formatting we already discussed, implements the solution from above and makes the driver use netdev_ops. Greetings, Phil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists