netdev - Re: [PATCH] fec: fix FEC driver packet transmission breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 09 Aug 2009 21:51:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerg@...pgear.com
Cc:	netdev@...r.kernel.org, gerg@...inux.org, s.hauer@...gutronix.de
Subject: Re: [PATCH] fec: fix FEC driver packet transmission breakage

From: Greg Ungerer <gerg@...pgear.com>
Date: Fri, 7 Aug 2009 13:58:18 +1000

> fec: fix FEC driver packet transmission breakage
> 
> Commit f0b3fbeae11a526c3d308b691684589ee37c359b 

In the future, when referencing commits, please also provide the
commit message header line text, in parenthesis, and in quotes, like
this ("the commit message header line"), right after the SHA1 ID.

I've fixed up your commit message, in that way, this time.  But
next time I'm going to simply shoot this back to you.

> breaks transmission of
> packets where the skb data buffer is not memory aligned according to
> FEC_ALIGNMENT. It incorrectly passes to dma_sync_single() the buffer
> address directly from the skb, instead of the address calculated for
> use (which may be the skb address or one of the bounce buffers).
> 
> It seems there is no use converting the cpu address of the buffer to
> a physical either, since dma_map_single() expects the cpu address and
> will return the dma address to use in the descriptor. So remove the use
> of __pa() on the buffer address as well.
> 
> This patch is against 2.6.30-rc5. This breakage is a regression over
> 2.6.30, which does not have this problem.
> 
> Signed-off-by: Greg Ungerer <gerg@...inux.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html