netdev - Re: [Resent][PATCH 1/2] inet6: Conversion from u8 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090810070800.GA6447@gerrit.erg.abdn.ac.uk>
Date:	Mon, 10 Aug 2009 09:08:00 +0200
From:	ext Gerrit Renker <gerrit@....abdn.ac.uk>
To:	R?mi Denis-Courmont <remi.denis-courmont@...ia.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [Resent][PATCH 1/2] inet6: Conversion from u8 to int

Quoting R?mi Denis-Courmont:
| On Sunday 09 August 2009 21:12:48 ext Gerrit Renker wrote:
| >  	case IPV6_TCLASS:
| >  		val = np->tclass;
| > -		if (val < 0)
| > -			val = 0;
| >  		break;
| 
| According to the IPv6 API RFC, if val is -1, the kernel shall pick the default 
| value (which is zero). Are you sure this still works??
Yes exactly that is the point, but it does not work since np->tclass is __u8, i.e.
val will not be negative here.

What you refer to is done in the second patch and in the combination I think it
will work, please have a look.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html