netdev - Re: [PATCH 5/6] [NET] ixp2000/enp2611: don't set non-existent member get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090810.080042.259707687.davem@davemloft.net>
Date:	Mon, 10 Aug 2009 08:00:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	linux-rt-users@...r.kernel.org, linux@....linux.org.uk,
	dbaryshkov@...il.com, kernel@...tstofly.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5/6] [NET] ixp2000/enp2611: don't set non-existent
 member get_stats

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Mon, 10 Aug 2009 11:40:27 +0200

> Yes, I tried that, but stopped when I saw it's declared const.  I don't
> know if this is required.  If yes then the only way to fix it is to add
> a platform callback that is called if non-NULL.

The easiest way to handle this is to have another copy of the ops,
which has the other get_stats member value, and to assign that as
the netdev_ops when the relevant condition holds.

> I don't want to invest time here without a word by the maintainers
> though.

But we can't apply the patch you initially posted, that's for sure
:-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html