netdev - Re: [PATCH 0/8] sky2: driver update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Aug 2009 21:09:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/8] sky2: driver update

From: Stephen Hemminger <shemminger@...tta.com>
Date: Thu, 06 Aug 2009 09:12:13 -0700

> This undoes the prematurely committed sky2 transmit logic changes
> and applies Mike's later changes.
> Here is a corrected patch stream please apply this to 2.6.31-rc5

I have to pass on this set, too many problems:

1) You didn't provide explicit "From: " lines for patches where
   you were not the author Stephen.  I could guess from the
   Signoff lines but I'd rather not.

2) I can almost swallow the cleanups if they make the bug fix
   coming up afterwards to be understood more easily.

   But I'm not going to apply patches right now that remove locking
   beause it "seems safe" or "should be ok".  That's absolutely not
   appropriate right now unless it fixes a performance regression
   explicitly listed in the formal regression list.  This is in
   reference to patch #5.

   If this is a prerequisite for patch #6 in some way (that's my
   guess), please make this more explicit, or even better change
   words like "should" (that sounds like "I'm not sure") into
   "is" when the commit message describes how the locks are no
   longer needed at that spot.

   Another idea is to combine #5 and #6 and explain the dependency
   in the commit message.

Also, to be honest, this kind of commit count is way too high at this
late stage of the RC series.  Nothing in here is super critical,
and none of it (to my knowledge) is in the regression list either.

And I informed you in private that the main reason I kept asking you
to be more responsive over the past month or so to sky2 patches and
bug reports was so that patches trickled in gradually, instead of
being dumped all at once way too late in the RC series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html