netdev - Pegasus: Bug / Correction (?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8447d6730908130311vd6984e8t1dd5c1e32efbeb2c@mail.gmail.com>
Date:	Thu, 13 Aug 2009 12:11:24 +0200
From:	Davide Rizzo <elpa.rizzo@...il.com>
To:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	petkan@...rs.sourceforge.net
Subject: Pegasus: Bug / Correction (?)

Bug Correction
ADM8515 fails to read central 2 bytes of MAC address
This patch solves the problem, but I didn't understand it.

Signed-off-by: Davide Rizzo <elpa.rizzo@...il.com>
---
diff -urNp linux-2.6.30.4/drivers/net/usb/pegasus.c
linux-2.6.30.4.elpa/drivers/net/usb/pegasus.c
--- linux-2.6.30.4/drivers/net/usb/pegasus.c	2009-08-13 07:14:57.000000000 +0200
+++ linux-2.6.30.4.elpa/drivers/net/usb/pegasus.c	2009-08-13
08:39:01.000000000 +0200
@@ -425,7 +425,6 @@ fail:
 static inline void enable_eprom_write(pegasus_t * pegasus)
 {
 	__u8 tmp;
-	int ret;

 	get_registers(pegasus, EthCtrl2, 1, &tmp);
 	set_register(pegasus, EthCtrl2, tmp | EPROM_WR_ENABLE);
@@ -434,7 +433,6 @@ static inline void enable_eprom_write(pe
 static inline void disable_eprom_write(pegasus_t * pegasus)
 {
 	__u8 tmp;
-	int ret;

 	get_registers(pegasus, EthCtrl2, 1, &tmp);
 	set_register(pegasus, EpromCtrl, 0);
@@ -486,9 +525,9 @@ static void set_ethernet_addr(pegasus_t
 {
 	__u8 node_id[6];

-	if (pegasus->features & PEGASUS_II) {
+/*if (pegasus->features & PEGASUS_II) {
 		get_registers(pegasus, 0x10, sizeof(node_id), node_id);
-	} else {
+	} else*/ {
 		get_node_id(pegasus, node_id);
 		set_registers(pegasus, EthID, sizeof (node_id), node_id);
 	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html