[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1250159961.28285.35.camel@Joe-Laptop.home>
Date: Thu, 13 Aug 2009 03:39:21 -0700
From: Joe Perches <joe@...ches.com>
To: Brian Haley <brian.haley@...com>
Cc: Jens Rosenboom <jens@...one.net>,
Linux Network Developers <netdev@...r.kernel.org>
Subject: Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
On Wed, 2009-08-12 at 21:33 -0400, Brian Haley wrote:
> Jens Rosenboom wrote:
> > Currently the output looks like 2001:0db8:0000:0000:0000:0000:0000:0001
> > which might be compacted to 2001:db8::1. The code to do this could be
> > adapted from inet_ntop in glibc, which would add about 80 lines to
> > lib/vsprintf.c. How do you guys value the tradeoff between more readable
> > logging and increased kernel size?
> >
> > This was already mentioned in
> > http://kerneltrap.org/mailarchive/linux-netdev/2008/11/25/4231684 but
> > noone seems to have taken up on it.
>
> Anyways, can you try this patch, it's less than 40 new lines :)
> It might be good enough, but could probably use some help.
You'll need to invent a new %p qualifier type to allow
compressed representation. Your patch will change current uses
with seq_<foo> output in net, which could break userspace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists