netdev - Re: [PATCH net-next-2.6] can: Use WARN_ONCE() instead of BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090814.163726.52442387.davem@davemloft.net>
Date:	Fri, 14 Aug 2009 16:37:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oliver@...tkopp.net
Cc:	urs@...ogud.escape.de, l.fu@...gutronix.de,
	m.olbrich@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] can: Use WARN_ONCE() instead of BUG_ON()
 for sanity check in receive path

From: Oliver Hartkopp <oliver@...tkopp.net>
Date: Fri, 14 Aug 2009 10:54:25 +0200

> To ensure a proper handling of CAN frames transported in skbuffs some checks
> need to be performed at receive time.
> 
> As stated by Michael Olbrich and Luotao Fu BUG_ON() might be to restrictive.
> This is right as we can just drop the non conform skbuff and the Kernel can
> continue working.
> 
> This patch replaces the BUG_ON() with a WARN_ONCE() so that the system remains
> healthy but we made the problem visible (once).
> 
> Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>
> Signed-off-by: Urs Thuermann <urs@...ogud.escape.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html