netdev - Re: [PATCH] s2io: Remove unnecessary casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090813.201452.21119996.davem@davemloft.net>
Date:	Thu, 13 Aug 2009 20:14:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dave@....org
Cc:	ram.vepa@...erion.com, santosh.rastapur@...erion.com,
	sivakumar.subramani@...erion.com, sreenivasa.honnur@...erion.com,
	anil.murthy@...erion.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] s2io: Remove unnecessary casts

From: Davidlohr Bueso <dave@....org>
Date: Thu, 13 Aug 2009 22:03:28 -0400

> 
> No need to cast kmalloc.
> 
> Signed-off-by: Davidlohr Bueso <dave@....org>

Yeah but:

>  
> -                                       ba->ba_0_org = (void *) kmalloc
> -                                           (BUF0_LEN + ALIGN_SIZE, GFP_KERNEL);
> +                                       ba->ba_0_org = kmalloc(BUF0_LEN + ALIGN_SIZE, GFP_KERNEL);

Now the code line extends way over 80 columns.

Please fix this up and resubmit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html