netdev - Re: [PATCH] net: add Xilinx emac lite device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090818140418.347cb8ac@nehalam>
Date:	Tue, 18 Aug 2009 14:04:18 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	John Linn <john.linn@...inx.com>
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org, jgarzik@...ox.com,
	davem@...emloft.net, John Linn <john.linn@...inx.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
	John Williams <john.williams@...alogix.com>,
	Michal Simek <michal.simek@...alogix.com>,
	Sadanand M <sadanan@...inx.com>
Subject: Re: [PATCH] net: add Xilinx emac lite device driver

On Tue, 18 Aug 2009 09:30:41 -0600
John Linn <john.linn@...inx.com> wrote:

> +/**
> + * xemaclite_enable_interrupts - Enable the interrupts for the EmacLite device
> + * @drvdata:	Pointer to the Emaclite device private data
> + *
> + * This function enables the Tx and Rx interrupts for the Emaclite device along
> + * with the Global Interrupt Enable.
> + */
> +static void xemaclite_enable_interrupts(struct net_local *drvdata)

Docbook format is really a not necessary on local functions that
are only used in the driver.  It is fine if you want to use it, as
long as the file isn't processed by kernel make docs but
the docbook is intended for automatic generation of kernel API manuals.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html