netdev - Re: Kernel oops on setting sky2 interfaces down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908192307.22112.rene.mayrhofer@gibraltar.at>
Date:	Wed, 19 Aug 2009 23:07:21 +0200
From:	Rene Mayrhofer <rene.mayrhofer@...raltar.at>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	netdev@...r.kernel.org, Richard Leitner <leitner@...s.at>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: Kernel oops on setting sky2 interfaces down

Hi Mike,

Am Mittwoch, 19. August 2009 17:00:31 schrieb Mike McCormack:
> * try the latest sky2 code from net-next-2.6
> * try adding an msleep(1) after sky2_rx_stop() in sky2_down()
> * try adding a check for rx_ring and tx_ring being NULL in
> sky2_status_intr(), and disable napi while freeing the buffers in
> sky2_down()
>
> I've got an untested, ad-hoc patch against net-next-2.6 for the last
> two bits ...

Pulling the latest sky2.c and sky2.h from net-next-2.6 and applying the patch 
rids me of the oops - it is unreproducible right now. However, a networking 
restart (i.e. all interfaces attached to sky2) leaves the devices in a state 
where they no longer receive any network packets (at least nothing visible in 
tcpdump). In this state, rmmod sky2 / modprobe sky2 gives:

[  718.502717] sky2 0000:01:00.0: unsupported chip type 0xff                    
[  718.510517] sky2: probe of 0000:01:00.0 failed with error -95                
[  718.517900] sky2 0000:02:00.0: unsupported chip type 0xff                    
[  718.524408] sky2: probe of 0000:02:00.0 failed with error -95                
[  718.531617] sky2 0000:03:00.0: unsupported chip type 0xff                    
[  718.538104] sky2: probe of 0000:03:00.0 failed with error -95                
[  718.545344] sky2 0000:04:00.0: unsupported chip type 0xff                    
[  718.551818] sky2: probe of 0000:04:00.0 failed with error -95 

I will now try the net-next-2.6 version without your patch again but was under 
the impression that it still oopsed when I tried it initially. Better to 
double-check before I give erroneous debugging results, though...

best regards,
Rene

-- 
-------------------------------------------------
Gibraltar firewall       http://www.gibraltar.at/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html