netdev - Re: [PATCH] ibm_newemac: emac_close() needs to call netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090819.143403.27319428.davem@davemloft.net>
Date:	Wed, 19 Aug 2009 14:34:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	pgynther@...gle.com, benh@...nel.crashing.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ibm_newemac: emac_close() needs to call
 netif_carrier_off()

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 19 Aug 2009 14:11:36 -0700

> On Wed, 19 Aug 2009 14:00:00 -0700 (PDT)
> Petri Gynther <pgynther@...gle.com> wrote:
> 
>> When ibm_newemac netdev instance is shutdown with "ifconfig down",
>> the netdev interface does not go properly down. netif_carrier_ok()
>> keeps returning TRUE even after "ifconfig down".
>> 
>> The problem can be seen when ibm_newemac instances are slaves of
>> a bonding interface. The bonding interface code uses netif_carrier_ok()
>> to determine the link status of its slaves. When ibm_newemac slave is
>> shutdown with "ifconfig down", the bonding interface won't detect any
>> link status change because netif_carrier_ok() keeps returning TRUE.
> 
> Bonding should be testing for netif_running() && netif_carrier_ok().
> 
> In many devices state of carrier is undefined when device is down.

But if you check all of the drivers, ethernet in particular, the
convention is to call netif_carrier_off() in foo_close().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html