[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20090818.202149.245453512.davem@davemloft.net>
Date: Tue, 18 Aug 2009 20:21:49 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: roel.kluin@...il.com
Cc: netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] yellowfin: Fix buffer underrun after dev_alloc_skb()
failure
From: Roel Kluin <roel.kluin@...il.com>
Date: Tue, 18 Aug 2009 10:50:34 +0200
> yellowfin_init_ring() needs to clean up if dev_alloc_skb() fails and
> should pass an error status up to the caller. This also prevents an
> buffer underrun if failure occurred in the first iteration.
> yellowfin_open() which calls yellowfin_init_ring() should free its
> requested irq upon failure.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists