netdev - Re: Kernel oops on setting sky2 interfaces down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <392fb48f0908190800j508456d6h9c520e82bc7f51e0@mail.gmail.com>
Date:	Thu, 20 Aug 2009 00:00:31 +0900
From:	Mike McCormack <mikem@...g3k.org>
To:	Rene Mayrhofer <rene.mayrhofer@...raltar.at>
Cc:	netdev@...r.kernel.org, Richard Leitner <leitner@...s.at>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: Kernel oops on setting sky2 interfaces down

2009/8/19 Rene Mayrhofer <rene.mayrhofer@...raltar.at>:
> Hi everybody,
>
> On Tuesday 11 August 2009 10:54:53 am Rene Mayrhofer wrote:
>> Thus, there really seems to be an uncaught case in sky2.c. When
>> sky2_phy_power_down is not called, chip should not go down, right? But
>> still sky2_poll seems to be called (maybe by an interrupt belonging to
>> another network interface but the same chip)?
>
> Is there anything else I could try? We still have this issue, making one range
> of hardware appliances unusable with 2.6 kernels...

Hi Rene,

There's a couple of things to try:

* try the latest sky2 code from net-next-2.6
* try adding an msleep(1) after sky2_rx_stop() in sky2_down()
* try adding a check for rx_ring and tx_ring being NULL in
sky2_status_intr(), and disable napi while freeing the buffers in
sky2_down()

I've got an untested, ad-hoc patch against net-next-2.6 for the last
two bits ...

thanks,

Mike

View attachment "sky2-bandaids.diff" of type "text/x-patch" (1382 bytes)