netdev - [PATCH] Fix useless test: int > INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4A8FE1D1.1030506@free.fr>
Date:	Sat, 22 Aug 2009 14:17:21 +0200
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...e.fr>
To:	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net
CC:	Cyril Chaboisseau <cyril.chaboisseau@...e.fr>
Subject: [PATCH] Fix useless test: int > INT_MAX

max_bonds is of type int and cannot be greater than INT_MAX.

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
---
  drivers/net/bonding/bond_main.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 4798d30..edd71a1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4755,7 +4755,7 @@ static int bond_check_params(struct bond_params *params)
  		params->ad_select = BOND_AD_STABLE;
  	}

-	if (max_bonds < 0 || max_bonds > INT_MAX) {
+	if (max_bonds < 0) {
  		pr_warning(DRV_NAME
  		       ": Warning: max_bonds (%d) not in range %d-%d, so it "
  		       "was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html