netdev - Re: [PATCH 1/2]: pkt_sched: Convert qdisc_watchdog to tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090822.175423.164703934.davem@davemloft.net>
Date:	Sat, 22 Aug 2009 17:54:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	netdev@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH 1/2]: pkt_sched: Convert qdisc_watchdog to
 tasklet_hrtimer

From: Jarek Poplawski <jarkao2@...il.com>
Date: Sat, 22 Aug 2009 14:04:31 +0200

> David Miller wrote, On 08/22/2009 02:03 AM:
> 
>> None of this stuff should execute in hw IRQ context, therefore
>> use a tasklet_hrtimer so that it runs in softirq context.
> 
> Do you mean __netif_schedule()?

No, that works fine from HW irq context.

> Could you explain it more?

It's that throttled flag bit setting.  It's still unsafe but at least
we're in a position now to use softirq locking or atomic bitops to
maintain it properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html