netdev - Re: [PATCH 1/2] Add an alternative cs89x0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090826104634.GA14425@e-circ.dyndns.org>
Date:	Wed, 26 Aug 2009 12:46:34 +0200
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver

Hi Sacha,

I'm using a 2.6.25.
Converting to your platform_device based driver,
I needed to configure the irq (see patch, irq flags).
Looking in the old cs89x0.c, it's done in the driver. Should I have
configured the irq level elsewhere? Or is this patch valid to do?

Kurt

Signed-off-by: Kurt Van Dijck <kurt.van.dijck@....be>
---
Index: drivers/net/cirrus-cs89x0.c
===================================================================
--- drivers/net/cirrus-cs89x0.c	(revision 7107)
+++ drivers/net/cirrus-cs89x0.c	(working copy)
@@ -487,7 +487,8 @@
        }
 
        /* install interrupt handler */
-       result = request_irq(ndev->irq, &cirrus_interrupt, 0, ndev->name, ndev);
+       result = request_irq(ndev->irq, &cirrus_interrupt,
+			IRQF_TRIGGER_HIGH, ndev->name, ndev);
        if (result < 0) {
                printk(KERN_ERR "%s: could not register interrupt %d\n",
                       ndev->name, ndev->irq);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html