lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Aug 2009 09:59:35 -0400 From: David Dillow <dave@...dillows.org> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Francois Romieu <romieu@...zoreil.com>, Michael Riepe <michael.riepe@...glemail.com>, Michael Buesch <mb@...sch.de>, Rui Santos <rsantos@...popie.com>, Michael B??ker <m.bueker@...lin.de>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] r8169: Reduce looping in the interrupt handler. On Wed, 2009-08-26 at 09:56 -0400, David Dillow wrote: > On Wed, 2009-08-26 at 00:58 -0700, Eric W. Biederman wrote: > > diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c > > index 3b19e0c..2214945 100644 > > --- a/drivers/net/r8169.c > > +++ b/drivers/net/r8169.c > > > + > > + /* Ignore the parts of status that reflect more than > > + * the enabled interrupts. > > + */ > > + smp_rmb(); > > + if (!(status & tp->intr_mask & tp->intr_event)) > > + break; > > } > > This looks like an odd construct, since we're just about to go back the > while condition up top -- why not just mask it here and let the loop > handle it naturally? Never mind, I see what you are doing -- avoiding a false loop if we get status == 0xffff. I still don't like the aesthetics of it, but it makes sense, and I'll blame it on the card. :) I should really get some caffeine before posting... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists