lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2009 08:36:41 +0000 From: Jarek Poplawski <jarkao2@...il.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, tglx@...utronix.de Subject: Re: [PATCH 1/2]: pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer On 22-08-2009 02:03, David Miller wrote: > None of this stuff should execute in hw IRQ context, therefore > use a tasklet_hrtimer so that it runs in softirq context. > > Signed-off-by: David S. Miller <davem@...emloft.net> > --- ... > void qdisc_watchdog_cancel(struct qdisc_watchdog *wd) > { > - hrtimer_cancel(&wd->timer); > + tasklet_hrtimer_cancel(&wd->timer); > wd->qdisc->flags &= ~TCQ_F_THROTTLED; > } > EXPORT_SYMBOL(qdisc_watchdog_cancel); I've had a second look at it and I wonder why it's not reported, but since qdisc_watchdog_cancel is run in qdisc_reset with BHs disabled it seems there should be (at least) a warning triggered in tasklet_kill on positive in_interrupt test (unless I miss something, but can't test it now). Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists