netdev - Re: [PATCH 1/7] sfc: Fix ordering of device registration and initial netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090826.180358.229467239.davem@davemloft.net>
Date:	Wed, 26 Aug 2009 18:03:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 1/7] sfc: Fix ordering of device registration and
 initial netif_carrier_off()

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 26 Aug 2009 19:16:27 +0100

> We must call netif_carrier_off() after the device is registered, not
> before, to set the operational state and user-space IFF_RUNNING flag
> correctly.
> 
> Since we don't want observers to see an intermediate state, open-code
> register_netdev() and add efx_update_name() and netif_carrier_off()
> into the locked region.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html