lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Aug 2009 12:15:39 -0400 (EDT) From: Christoph Lameter <cl@...ux-foundation.org> To: Eric Dumazet <eric.dumazet@...il.com> cc: Sridhar Samudrala <sri@...ibm.com>, David Stevens <dlstevens@...ibm.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, niv@...ux.vnet.ibm.com Subject: Re: UDP multicast packet loss not reported if TX ring overrun? On Fri, 28 Aug 2009, Eric Dumazet wrote: > "tc -s qdisc show" only displays queue info for tx packets. Duh. The packet counters and bytes are way out of whack and do not reflect what was actually sent. This must be some other qdisc. > > sch->qstats.drops++; > > > > + /* device queue statistics */ > > + sch->dev_queue->tx_dropped++; > > + > > return NET_XMIT_DROP; > > } > > locking problem here, tx_dropped can be changed by another cpu. Who cares. It just was for debugging. > As David Stevens pointed out, device was not ever called at all when your packet(s) was/were lost. > Why should we account a non existent drop at device level ? Because you need drop statistics on a device to figure out when you may want to increase the TX buffers for a device. If a packet was dropped because of a lack of TX buffers then we need to know. > When a process wants a new memory page and hits its own limit, do you want to increment a system global > counter saying 'memory allocation failed' ? When a process allocates and locks all of memory then you get an OOM. > Only change you want is eventually to account for the UDP drop (SndbufErrors). That is only a counter at the UDP layer. That one does not allow you to identify which NIC it was nor which application caused it. But its already a big improvement to see TX drops at all. Could we get your latest patch merged soon? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists