netdev - Re: [PATCH REPOST net-next-2.6 3/4] bonding: Fix useless test: int > INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23655.1251501514@death.nxdomain.ibm.com>
Date:	Fri, 28 Aug 2009 16:18:34 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	David Miller <davem@...emloft.net>
cc:	netdev@...r.kernel.org, nicolas.2p.debian@...e.fr
Subject: Re: [PATCH REPOST net-next-2.6 3/4] bonding: Fix useless test: int > INT_MAX

David Miller <davem@...emloft.net> wrote:

>From: Jay Vosburgh <fubar@...ibm.com>
>Date: Fri, 28 Aug 2009 15:05:14 -0700
>
>> From: Nicolas de PesloÃ¼an <nicolas.2p.debian@...e.fr>
>> 
>> max_bonds is of type int and cannot be greater than INT_MAX.
>> 
>> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
>> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
>
>It seems you use two different encodings here for Nicolas's
>last name, and thus the two-dotted 'u' comes out corrupted
>in the From: field.
>
>This causes patchwork to not be able to parse the patch
>and thus put it properly into the queue.  So all that's
>in there are patches #1, #2 and #4.

	Hmm.  Does this one work any better?  I just copied the
Signed-off-by text into the From: line.

	-J


From: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
Date: Sat, 22 Aug 2009 14:17:21 +0200
Subject: [PATCH REPOST net-next-2.6 3/4] bonding: Fix useless test: int > INT_MAX
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

max_bonds is of type int and cannot be greater than INT_MAX.

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
---
 drivers/net/bonding/bond_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index ed00ba9..6b9f15b 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4759,7 +4759,7 @@ static int bond_check_params(struct bond_params *params)
 		params->ad_select = BOND_AD_STABLE;
 	}
 
-	if (max_bonds < 0 || max_bonds > INT_MAX) {
+	if (max_bonds < 0) {
 		pr_warning(DRV_NAME
 		       ": Warning: max_bonds (%d) not in range %d-%d, so it "
 		       "was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",
-- 
1.6.0.2



---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html