netdev - Re: [PATCH 08/14] pktgen: reorganize transmit loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090827224902.49f80920@nehalam>
Date:	Thu, 27 Aug 2009 22:49:02 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	David Miller <davem@...emloft.net>,
	Robert Olsson <robert.olsson@....uu.se>,
	netdev@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 08/14] pktgen: reorganize transmit loop

On Thu, 27 Aug 2009 20:52:32 -0700
Ben Greear <greearb@...delatech.com> wrote:

> +		default: /* Drivers are not supposed to return other
> values! */
> +			if (net_ratelimit())
> +				pr_info("pktgen: %s xmit error:
> %d\n",
> +					odev->name, ret);
>  			pkt_dev->errors++;
> 
> I believe this is faulty.  Things like vlans can send pkts to qdiscs
> of the underlying device and those can return other values.
> 
> Patric McHardy put in some patches recently to achieve this in a more
> uniform manner:
> 
> http://patchwork.ozlabs.org/patch/28340/
> 
> Thanks,
> Ben
> 

Since pktgen has its own way of generating vlan tags, it
makes no sense to use it on top of 8021q vlan driver.


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html