netdev - Re: Subject: [PATCH 1/9] bna: Brocade 10Gb Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090828.231821.228158617.davem@davemloft.net>
Date:	Fri, 28 Aug 2009 23:18:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rmody@...cade.com
Cc:	netdev@...r.kernel.org, amathur@...cade.com
Subject: Re: Subject: [PATCH 1/9] bna: Brocade 10Gb Ethernet device driver

You're going to have to remove all of the
__ESX_COS__, __VMKERNEL_MODULE__, __VMKNETDDI_QUEUEOPS__
ifdef tests and protected code in this driver.

Nothing sets those CPP defines, and the Linux kernel is not
a place where you can maintain your compatability code for
building the driver in other environments.

Next, you have defined your own implementation of a driver
debug logging facility, when we have a generic one already
for network drivers via netif_msg_*() and associated
NETIF_MSG_* debugging masks.  See other drivers for details.
If it doesn't fully suit your needs, fix the existing
facilities to do so.

These are just the most obvious things I noticed by glancing
quickly at your driver.  I'm sure there a many other things
you will need to fix up before we can add your driver.

The code is 1MB in size, which almost guarentees there are lots of
things which will need to be removed :-) Even the largest 10GB drivers
with tons of firmware are ~500K in size and I even consider that
bordering on excessive.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html