netdev - Re: [PATCH] sky2: Don't try to turn led off in sky2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090829105727.6281202e@s6510>
Date:	Sat, 29 Aug 2009 10:57:27 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org,
	Rene Mayrhofer <rene.mayrhofer@...raltar.at>,
	Richard Leitner <leitner@...s.at>
Subject: Re: [PATCH] sky2: Don't try to turn led off in sky2_down()

On Sat, 29 Aug 2009 22:10:33 +0900
Mike McCormack <mikem@...g3k.org> wrote:

> There are a few problems with the following line of code in sky2_down()
> 
>      sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
> 
>  * It doesn't specify which port's LED to turn off.
>  * We don't turn send LED_STAT_ON on in sky2_up()
>  * B0_LED is 0x0006 in the vendor driver, but 0x0005 in sky2.
>    B0_LED is right next to B0_POWER_CTRL, so this is possibly
>    accounts for the device being accidently powered down as
>    reported by Rene Mayrhofer.

I would rather just change the definition of B0_LED to the correct value.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html