netdev - RE: [PATCH] net-next:can: add TI CAN (HECC) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2A3DCF3DA181AD40BDE86A3150B27B6B02F6211B1A@dbde02.ent.ti.com>
Date:	Tue, 1 Sep 2009 15:02:00 +0530
From:	"Gole, Anant" <anantgole@...com>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	"socketcan-core@...ts.berlios.de" <socketcan-core@...ts.berlios.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net-next:can: add TI CAN (HECC) driver


[snip]
>>
>> This driver is tested on OMAP3517 EVM. Suspend/Resume not tested as yet.
>
>One minor thing I found while glimpsing at the code...
>
[snip]
>> +	}
>> +	if (!request_mem_region(mem->start, (mem->end - mem->start) + 1,
>
>Use resource_size(mem).
>
>> +		pdev->name)) {
>> +		printk(KERN_ERR "HECC region already claimed\n");
>> +		err = -EBUSY;
>> +		goto probe_exit;
>> +	}
>> +	addr = ioremap(mem->start, mem->end - mem->start + 1);
>
>ditto

Ack. Thanks for the comment. I will include in V2 patch.

Regards,
Anant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html