netdev - Re: [PATCH NEXT 2/3] netxen: remove duplicate napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090903.200719.210860351.davem@davemloft.net>
Date:	Thu, 03 Sep 2009 20:07:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dhananjay@...xen.com
Cc:	davem@...emloft.com, netdev@...r.kernel.org
Subject: Re: [PATCH NEXT 2/3] netxen: remove duplicate napi_add

From: Dhananjay Phadke <dhananjay@...xen.com>
Date: Thu,  3 Sep 2009 16:10:54 -0700

> Remove duplicate calls to netxen_napi_add().
> 
> Signed-off-by: Dhananjay Phadke <dhananjay@...xen.com>

Applied, but:

> @@ -2038,8 +2034,6 @@ netxen_remove_sysfs_entries(struct netxen_adapter *adapter)
>  		device_remove_file(dev, &dev_attr_bridged_mode);
>  }
>  
> -static void netxen_watchdog(unsigned long);
> -
>  #ifdef CONFIG_INET
>  
>  #define is_netxen_netdev(dev) (dev->netdev_ops == &netxen_netdev_ops)

Give me a friggin' break, really.

If you're going to slip unrelated cleanups like this into your
patches, at least DOCUMENT them in the commit message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html